MakeSense for GitHub — Make Sense of Any GitHub PR, with full cognitive coverage of every change.
sadmann7/tablecn#1143 — 4 files, 0 review comments
Implement Sticky Headers and Fixed Height for Data Tables
Overview
Data tables now support sticky headers and a maximum height. Users can scroll table bodies while headers remain visible. This improves usability for large datasets.
Technical Highlights
src/components/data-table/data-table.tsx: Applies conditional styling for sticky headers and height based on `meta` options.
src/components/ui/table.tsx: Adds a `containerStyle` prop to the base `Table` component's wrapper `div`.
src/lib/data-table.ts: Provides a reusable utility function to generate CSS for sticky table headers.
src/types/data-table.ts: Extends `TableMeta` with `stickyHeader` (boolean) and `maxHeight` (string) properties.
Impact
Functionality: Data tables now offer persistent headers and scrollable bodies for improved large data display.
Risk: Existing table styling or layout might conflict with new container styles or `overflowY` properties.
Files reviewed
- src/components/data-table/data-table.tsx — 0 comment(s)
- src/components/ui/table.tsx — 0 comment(s)
- src/lib/data-table.ts — 0 comment(s)
- src/types/data-table.ts — 0 comment(s)
View the full interactive review (JavaScript required).
