MakeSense for GitHub — Make Sense of Any GitHub PR, with full cognitive coverage of every change.
HexmosTech/git-lrc#131 — 3 files, 2 review comments
Resolve Dynamic Sign-in Base URL
Overview
The system now dynamically determines the sign-in base URL. It supports self-hosted instances and environment variable overrides. This ensures users are directed to the correct login page.
Technical Highlights
`setup/login_server.go`: Introduces `ResolveSigninBase` to centralize sign-in URL derivation logic.
`setup/login_server.go`: Updates `BuildSigninURL` to accept `apiURL` and utilize `ResolveSigninBase`.
`setup/login_server.go`: Adds `SigninURLEnv` for environment variable override of the sign-in URL.
`internal/appui/setup_flow.go`: Passes `apiURL` to `BuildSigninURL` for correct base URL determination.
`setup/login_server_test.go`: Adds comprehensive tests for `ResolveSigninBase` and updated `BuildSigninURL` scenarios.
Impact
Functionality: CLI login flow now correctly directs users to self-hosted or cloud sign-in pages.
Risk: Incorrect `apiURL` or `SigninURLEnv` configuration could lead to login redirection failures.
Files reviewed
- internal/appui/setup_flow.go — 0 comment(s)
- setup/login_server.go — 2 comment(s)
- setup/login_server_test.go — 0 comment(s)
View the full interactive review (JavaScript required).
